To: vim_dev@googlegroups.com Subject: Patch 8.2.4531 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.4531 Problem: LGTM warnings for condition always true and buffer size too small. Solution: Remove the useless condition. Make the buffer larger. (Goc Dundar, closes #9914) Files: src/charset.c, src/term.c *** ../vim-8.2.4530/src/charset.c 2022-03-03 20:03:44.657088284 +0000 --- src/charset.c 2022-03-09 12:54:40.493489666 +0000 *************** *** 558,564 **** charbuf[1] = c ^ 0x40; // DEL displayed as ^? charbuf[2] = NUL; } ! else if (enc_utf8 && c >= 0x80) { transchar_hex(charbuf, c); } --- 558,564 ---- charbuf[1] = c ^ 0x40; // DEL displayed as ^? charbuf[2] = NUL; } ! else if (enc_utf8) { transchar_hex(charbuf, c); } *** ../vim-8.2.4530/src/term.c 2022-03-07 13:31:10.704100882 +0000 --- src/term.c 2022-03-09 12:59:00.073023855 +0000 *************** *** 6370,6376 **** static void req_more_codes_from_term(void) { ! char buf[11]; int old_idx = xt_index_out; // Don't do anything when going to exit. --- 6370,6376 ---- static void req_more_codes_from_term(void) { ! char buf[23]; // extra size to shut up LGTM int old_idx = xt_index_out; // Don't do anything when going to exit. *** ../vim-8.2.4530/src/version.c 2022-03-09 11:56:17.873358764 +0000 --- src/version.c 2022-03-09 12:57:22.249199584 +0000 *************** *** 752,753 **** --- 752,755 ---- { /* Add new patch number below this line */ + /**/ + 4531, /**/ -- hundred-and-one symptoms of being an internet addict: 214. Your MCI "Circle of Friends" are all Hayes-compatible. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///